Skip to content

Fix malformed cf_12 filter in release notes Redmine link#2302

Open
ogajduse wants to merge 1 commit into
theforeman:gh-pagesfrom
ogajduse:fix/release-notes-cf12-filter-link
Open

Fix malformed cf_12 filter in release notes Redmine link#2302
ogajduse wants to merge 1 commit into
theforeman:gh-pagesfrom
ogajduse:fix/release-notes-cf12-filter-link

Conversation

@ogajduse

@ogajduse ogajduse commented Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

  • `scripts/release_notes.rb` builds a Redmine link for the full issue list, but used `v[cf_12]=` instead of the array form `v[cf_12][]=` used by the actual API query a few lines above.
  • Redmine expects the array form for this filter; the malformed param gets silently dropped, so opening the link shows an empty Filters section instead of the intended cf_12 filter.

Test plan

  • Run `./scripts/release_notes.rb foreman ` and confirm the printed Redmine link shows the cf_12 filter applied when opened in a browser

@ogajduse
Fix malformed cf_12 filter in release notes Redmine link
4c6d209 
v[cf_12]= needs to be v[cf_12][]= (array form) to match Redmine's
expected filter param format, otherwise the filter is silently
dropped and the Issues page Filters section renders empty.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Not yet reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ogajduse